Open
Conversation
- Add profile properties for getting expenses and revenues with 'needs reimbursement' status. - Update expense signal handler to use new property and add new signal handler for revenues.
tykling
reviewed
Feb 21, 2026
tykling
reviewed
Feb 21, 2026
Comment on lines
+83
to
+104
| def reimbursement_msg_on_login(sender, request, user, **kwargs) -> None: | ||
| """Add message for reminding user about missing reimbursement.""" | ||
| expenses = user.profile.paid_expenses_needs_reimbursement | ||
| if expenses.exists(): | ||
| msg = ( | ||
| f"NOTE: You have {expenses.count()} expense(s) with missing " | ||
| "reimbursement. Please create a reimbursement once all your " | ||
| "expenses have been approved." | ||
| ) | ||
| messages.info(request, msg) | ||
|
|
||
|
|
||
| def redisbursement_msg_on_login(sender, request, user, **kwargs) -> None: | ||
| """Add message for reminding user about missing redisbursement.""" | ||
| revenues = user.profile.paid_revenues_needs_redisbursement | ||
| if revenues.exists(): | ||
| msg = ( | ||
| f"NOTE: You have {revenues.count()} revenue(s) with missing " | ||
| "redisbursement. Please create a redisbursement once all your " | ||
| "revenue(s) have been approved." | ||
| ) | ||
| messages.info(request, msg) |
Member
There was a problem hiding this comment.
Suggested change
| def reimbursement_msg_on_login(sender, request, user, **kwargs) -> None: | |
| """Add message for reminding user about missing reimbursement.""" | |
| expenses = user.profile.paid_expenses_needs_reimbursement | |
| if expenses.exists(): | |
| msg = ( | |
| f"NOTE: You have {expenses.count()} expense(s) with missing " | |
| "reimbursement. Please create a reimbursement once all your " | |
| "expenses have been approved." | |
| ) | |
| messages.info(request, msg) | |
| def redisbursement_msg_on_login(sender, request, user, **kwargs) -> None: | |
| """Add message for reminding user about missing redisbursement.""" | |
| revenues = user.profile.paid_revenues_needs_redisbursement | |
| if revenues.exists(): | |
| msg = ( | |
| f"NOTE: You have {revenues.count()} revenue(s) with missing " | |
| "redisbursement. Please create a redisbursement once all your " | |
| "revenue(s) have been approved." | |
| ) | |
| messages.info(request, msg) | |
| def reimbursement_msg_on_login(sender, request, user, **kwargs) -> None: | |
| """Add message for reminding user about missing reimbursement.""" | |
| expenses = user.profile.paid_expenses_needs_reimbursement | |
| revenues = user.profile.paid_revenues_needs_redisbursement | |
| if expenses.exists() or revenues.exists(): | |
| msg = ( | |
| f"NOTE: You have {expenses.count()} expense(s) and " | |
| f"{revenues.count()} revenues(s) with missing " | |
| "reimbursement. Please create a reimbursement once all your " | |
| "expenses and revenues have been created and approved." | |
| ) | |
| messages.info(request, msg) |
Member
There was a problem hiding this comment.
reimbursements cover both expenses and revenues, changed the wording a bit and changed so there is only 1 message
tykling
requested changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2044